feat: add logger class util in @metamask/snap-networks-utils - #136
Open
taran-a wants to merge 1 commit into
Open
feat: add logger class util in @metamask/snap-networks-utils#136taran-a wants to merge 1 commit into
taran-a wants to merge 1 commit into
Conversation
|
|
||
| constructor({ | ||
| enabled, | ||
| level = LogLevel.TRACE, |
Contributor
There was a problem hiding this comment.
Shall we using super struct to gate the config / coerce the config, since TS is fake strong type
especially the level , it is nice to have not a blocker
sth like that
export const LogLevelStruct = coerce(
defaulted(enums(Object.values(LogLevel)), LogLevel.ERROR),
string(),
(value: string) => (value === '' ? undefined : value.toLowerCase()),
);
|
|
||
| ## Usage | ||
|
|
||
| ```typescript |
Contributor
There was a problem hiding this comment.
May be we dont need to add a additional readme?
the "example / how to use" can include form the JS DOC of the logger
hence, Editor hover / autocomplete will appear to the developer ?
wdyt?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Snap-networks-utils package update
Add Logger shared utils class. See readme file with the usage exmaples.
References
Checklist